fix: detect .bat and .cmd executables on Windows#81
Open
Conversation
Member
Author
|
This PR didn't seem to work for the person who reported the issue. Needs manual testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, aw-qt wouldn't detect modules as they end in
.cmdor.bat(not sure which).Reported here: https://discord.com/channels/755040852727955476/755334568977891348/956531050627104832
The user got the following output:
Not sure why aw-client becomes an .exe but aw-server etc becomes a .bat or .cmd