RIDE 🚗 SHARE 🚗 danielle 🚗 sammi-jo 🚗 #15

sjlee3157 · 2018-10-05T23:02:23Z

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	A driver has many trips, a passenger has many trips, and each trip has one and only one driver and passenger. We set it up this way to be able to view and access data between models.
Describe the role of model validations in your application	To prevent incomplete or inaccurate data types from being saved into the database by the user.
How did your team break up the work to be done?	We set up the project foundations together, which allowed us to think and talk about what pieces of the app were similar enough to be done by one person (e.g. driver/passenger view pages). For the work we did independently, we decided what parts of the app were independent enough that our work wouldn't conflict. For example, typically only one person was styling CSS at a time.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized the project requirements before any styling. Once the minimum required back-end code was written, we also prioritized any CSS styling that was high-impact or high-satisfaction so that our site would look good and be fun to work on.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We gained a better understanding on routes along with how to use models and access those models from other controllers. We also felt like we were able to plan this project better and manage our time with the different parts (back-end, front-end).
What is your Trello board URL?	https://trello.com/b/lX9w1iZz/sammi-jo-danielle
What is the Heroku URL of your deployed application?	https://take-a-little-trip.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	Sammi-Jo: I appreciate how Danielle kept me from getting sidetracked in Rails by suggesting a simple solution that we've seen before from ada books.
Danielle Metzner: I really appreciated Sammi-Jo's input and feedback when we were trying to find bugs in our code, she was really amazing at finding simple things I missed. She was also super good about creating visibility with Trello about what we were working on :) .

…ngers

…ike find_by

CheezItMan · 2018-10-08T22:25:43Z

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and both partners contributing	Good number of commits and good commit messages, both partners contributed.
Answered comprehension questions	Check, I'm glad you seemed to work well together
Uses named routes (like `_path`)	Check
RESTful routes utilized	Check with
Project Requirements
Table relationships	Check
Validation rules for Models	Check
Business logic is in the models	Check, lots of good methods in the models.
Database is seeded from the CSV files	Check
Trello board is created and utilized in project management	Check
Heroku instance is online	Check
The app is styled to create an attractive user interface	Nice styling, good front-end validations
Overall	Good work, you hit the learning goals and did a nice job on validations. You also validated things on the browser side with HTML validations as well as the model. Nice!

CheezItMan · 2018-10-07T23:03:29Z

app/views/drivers/show.html.erb

+<button><%= link_to "Delete", driver_path(@driver.id), method: :delete, data: {confirm: 'Are you sure you want to delete this driver?'} %></button>
+
+
+<%= render partial: "layouts/personaltrips",


Good idea to use a partial in the show view!

CheezItMan · 2018-10-07T23:05:08Z

app/views/layouts/_form.html.erb

+  <div id="form-div">
+
+
+  <%= form_with model: model, url: url, method: method, class:"form" , id:"form1" do |f| %>


I think with the state of the model you don't need to specify the url field.

CheezItMan · 2018-10-07T23:05:57Z

config/routes.rb

+  resources :trips, except: [:create, :new]
+  resources :drivers
+  resources :passengers, except: [:show] do
+    resources :trips, only: [:index, :show, :create]


Do you need the index and show actions here?

You are using the trips index page to show the details on the passenger, rather than details on the passenger. It works, but kinda odd.

CheezItMan · 2018-10-07T23:07:37Z

app/views/trips/edit.html.erb

@@ -0,0 +1,26 @@
+<div id="form-main">


Do you need to have a separate screen to edit a trip? Could you instead rate the trip on the passenger's show page?

CheezItMan · 2018-10-07T23:09:17Z

app/models/driver.rb

@@ -0,0 +1,50 @@
+class Driver < ApplicationRecord
+  has_many :trips, dependent: :nullify


Interesting way to handle the deletion of Drivers. This will work, but leave trips without a driver.

CheezItMan · 2018-10-07T23:22:25Z

app/views/trips/edit.html.erb

+          <% cost_placeholder = @trip.formatted_cost %>
+          <% value_placeholder = @trip.formatted_cost %>
+        <% end %>
+      <%= f.text_field :cost, value: cost_value, placeholder: cost_placeholder, pattern: '\d{1,3}.\d{2}', required: true, class: "feedback-input", id: "cost_image" %>


It's good that you're using front-end validations, but you still need model validations!

CheezItMan · 2018-10-07T23:23:24Z

app/models/driver.rb

+
+  def total_earnings
+  #The driver gets 80% of the trip cost after a fee of $1.65 is subtracted
+    total_cost = self.trips.reduce(0) { |sum, trip|


Good use of reduce!

As a style comment, instead of using { } for multiline blocks use do ... end instead.

CheezItMan · 2018-10-07T23:24:56Z

app/models/trip.rb

+    end
+  end
+
+  def assign_random_cost


This should probably be a self method or actually change the cost field of the Trip.

CheezItMan · 2018-10-07T23:25:51Z

app/models/passenger.rb

+
+  def status
+    if self.trips.any? { |trip| trip.cost == nil || trip.rating == nil }
+      return :in_progress


Semantically this would probably be better to return :on_trip

CheezItMan · 2018-10-08T22:24:27Z

app/models/trip.rb

+  belongs_to :passenger
+  validates :date, presence: true
+  validates :rating, presence: {message: "can't be blank. Trip won't end until you select a rating." }, unless: :passenger_is_requesting_trip
+  validates :cost, presence: {message: "can't be blank."}, unless: :passenger_is_requesting_trip


Neat validations, and custom messages.

sjlee3157 and others added 30 commits October 1, 2018 15:56

Run Rails new

ea00dc0

Created Passengers controller and model, and updated routes for Passe…

c01c51b

…ngers

Added Driver controller, model, and routes resources

1d87b64

Merge branch 'master' of https://github.com/sjlee3157/ride-share-rails

4df58c2

Added Trip controller, model, and route resources

8683477

Added foreign keys for driver and passenger to trips DB

bbbe3eb

Added relationships to driver and passenger models

8aa0b1f

Added controller methods to passenger

95e948a

Fixed passengers destroy method

60f652a

Added Driver controller methods

fda6562

Merge branch 'master' of https://github.com/sjlee3157/ride-share-rails

8dd3daa

Added controller methods for trip

488063d

Added total_earnings method into active record for Driver

1a8dd28

Added average rating for driver. Woohoo

491d3d2

Added _new partial and new views for Passenger and Driver

437d9b7

Merge branch 'master' of https://github.com/sjlee3157/ride-share-rails

1497ca2

Added total_cost method to Passenger

8951e07

Merge branch 'master' of https://github.com/sjlee3157/ride-share-rails

74a1d5d

Updated trip controller to have capital Trip to access Trip methods l…

6e91f50

…ike find_by

Added is_available for driver model

8ca082a

Added Driver class method to find first available driver

7bba47b

Removed trips#new route + wrote code in trips#create

882c1de

nav bar stuff

2ba3a36

Added CSS for Raleway font

ba574a1

Nav bar links done

4e3036f

Updated nav bar

72c1229

Fixed bug - capitalized Trip in TripsController

1cf62e5

tiny update in new driver view

982b920

Added table to passengers index

ed15b1f

Created view for Drivers table

7e2b03b

danimetz and others added 28 commits October 5, 2018 14:57

It formats the update trip page

0b23689

Merge branch 'master' of https://github.com/sjlee3157/ride-share-rails

676e469

Savepoint

dec6999

Loophole: driver show links to END TRIP for inprogress trip

84e99cf

More trip edit styling

e5e55b8

Merge branch 'master' of https://github.com/sjlee3157/ride-share-rails

1734bf0

Savepoint before Heroku deploy

12e503f

Savepoint before Heroku deploy

6431d47

Savepoint

085d30b

Fixed css bug deleted extra css

38baf05

Centered the title text on the nav bar

2ebc8e9

Orange homepage title text..?

979431d

Edit homepage title text

853b0f4

Merge

384b7d8

Updated update trip paths in the controller

c537bea

Added validations to models

4c560a2

updated regex for trips

abd6ac0

Successfully rendered error messages for drivers

1c185b3

Added validition error messages to trips and passengers

c7f9d35

Styled Edit and Delete links

da7ee35

Merge branch 'master' of https://github.com/sjlee3157/ride-share-rails

deb2fdf

Added a missing class tag for edit link

db5f806

Found bug with new trip / end trip validation

dcf9ff6

Edit driver now prints the right error messages

ffd6184

Fixed bug in Passenger edit - error messages now print

e6c447f

Fixed (?) bug with request a trip

e18dc44

Fixed bug with selectors for Edit and Delete links

05e9c05

Fixed bugs with ending trip validation

cc560af

CheezItMan reviewed Oct 8, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RIDE 🚗 SHARE 🚗 danielle 🚗 sammi-jo 🚗 #15

RIDE 🚗 SHARE 🚗 danielle 🚗 sammi-jo 🚗 #15

Uh oh!

sjlee3157 commented Oct 5, 2018 •

edited

Loading

Uh oh!

CheezItMan commented Oct 8, 2018

Uh oh!

CheezItMan Oct 7, 2018

Uh oh!

CheezItMan Oct 7, 2018

Uh oh!

CheezItMan Oct 7, 2018

Uh oh!

CheezItMan Oct 7, 2018

Uh oh!

CheezItMan Oct 7, 2018

Uh oh!

CheezItMan Oct 7, 2018

Uh oh!

CheezItMan Oct 7, 2018

Uh oh!

CheezItMan Oct 7, 2018

Uh oh!

CheezItMan Oct 7, 2018

Uh oh!

CheezItMan Oct 8, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		<button><%= link_to "Delete", driver_path(@driver.id), method: :delete, data: {confirm: 'Are you sure you want to delete this driver?'} %></button>


		<%= render partial: "layouts/personaltrips",

		<div id="form-div">


		<%= form_with model: model, url: url, method: method, class:"form" , id:"form1" do \|f\| %>

		@@ -0,0 +1,50 @@
		class Driver < ApplicationRecord
		has_many :trips, dependent: :nullify

RIDE 🚗 SHARE 🚗 danielle 🚗 sammi-jo 🚗 #15

Are you sure you want to change the base?

RIDE 🚗 SHARE 🚗 danielle 🚗 sammi-jo 🚗 #15

Uh oh!

Conversation

sjlee3157 commented Oct 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rideshare-Rails

Comprehension Questions

Uh oh!

CheezItMan commented Oct 8, 2018

Rideshare Rails

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sjlee3157 commented Oct 5, 2018 •

edited

Loading