-
Notifications
You must be signed in to change notification settings - Fork 49
ports-sav #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ports-sav #42
Conversation
…tabase, added time-zone to intializers for PDT.
Task ListWhat We're Looking For
|
CheezItMan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, good job with testing!
| get edit_task_path(3) | ||
| must_respond_with :redirect | ||
| must_redirect_to tasks_path | ||
| expect(flash[:error]).must_equal "Could not find task with id: 3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
| def destroy | ||
| task_id = params[:id] | ||
| task = Task.find_by(id: task_id) | ||
| task.destroy if task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some sort of feedback if task is nil should be provided to the user.
| <ol class="inner_scroll"> | ||
| <%@tasks.each do |task|%> | ||
| <li class="task"> | ||
| <a href="/tasks/<%=task.id%>"><h3>Task: <span><%= task.name%></span></h3></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use link_to here, and a named path.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions