Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/heap_sort.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,15 @@
# Time Complexity: ?
# Space Complexity: ?
def heap_sort(list)
raise NotImplementedError, "Method not implemented yet..."
heap = MinHeap.new

list.each do |elem|
heap.add(elem)
end

sorted = []
heap.each do |elem|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heaps don't have a .each method.

Suggested change
heap.each do |elem|
while !heap.empty?

sorted << heap.remove(elem)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove doesn't take an argument.

end
return sorted
end
59 changes: 43 additions & 16 deletions lib/min_heap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,23 @@ def initialize
end

# This method adds a HeapNode instance to the heap
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n), where n is the number of nodes in heap
# Space Complexity: O(log n), where n is the number of nodes in heap
Comment on lines +17 to +18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

def add(key, value = key)
raise NotImplementedError, "Method not implemented yet..."
@store << HeapNode.new(key, value)
heap_up(@store.length - 1)
end

# This method removes and returns an element from the heap
# maintaining the heap structure
# Time Complexity: ?
# Space Complexity: ?
# Time Complexity: O(log n), where n is the number of nodes in heap
# Space Complexity: O(1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since heap_down is recursive, you will be using the call stack, so the space complexity is O(log n)

def remove()
raise NotImplementedError, "Method not implemented yet..."
swap(0, @store.length - 1)
answer = @store.pop
heap_down(0)

return answer.value
end


Expand All @@ -44,28 +49,50 @@ def to_s
end

# This method returns true if the heap is empty
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(1)
# Space complexity: O(1)
def empty?
raise NotImplementedError, "Method not implemented yet..."
return @store.empty?
end

private

# This helper method takes an index and
# moves it up the heap, if it is less than it's parent node.
# It could be **very** helpful for the add method.
# Time complexity: ?
# Space complexity: ?
# Time complexity: O(log n), where n is the number of nodes in heap
# Space complexity: O(log n), where n is the number of nodes in heap
def heap_up(index)
return if index == 0

parent = (index - 1) / 2
if @store[parent].key > @store[index].key
swap(parent, index)
heap_up(parent)
else
return
end
end

# This helper method takes an index and
# moves it up the heap if it's smaller
# than it's parent node.
def heap_down(index)
raise NotImplementedError, "Method not implemented yet..."
left_child = index * 2 + 1
right_child = index * 2 + 2

if left_child > @store.length - 1
return
elsif right_child > @store.length - 1
if @store[index].key > @store[left_child].key
swap(left_child, index)
end
return
end

if @store[left_child].key < @store[right_child].key
swap(left_child, index)
heap_down(left_child)
else
swap(right_child, index)
heap_down(right_child)
end
end

# If you want a swap method... you're welcome
Expand Down