forked from AdaGold/heaps
-
Notifications
You must be signed in to change notification settings - Fork 34
Evelynn #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
evelynnkaplan
wants to merge
6
commits into
Ada-C11:master
Choose a base branch
from
evelynnkaplan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Evelynn #20
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
70979f9
completed add and heap_up
evelynnkaplan d3399fd
completed heap_down, remove, and empty?
evelynnkaplan 68c3d5f
added space/time complexity
evelynnkaplan 36a859b
completed heapsort
evelynnkaplan 7057b70
added space/time complexity
evelynnkaplan 6b0d067
added comment
evelynnkaplan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,24 @@ | ||
|
|
||
| require_relative "./min_heap" | ||
| require "pry" | ||
|
|
||
| # This method uses a heap to sort an array. | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def heap_sort(list) | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| end | ||
| # Time Complexity: O (n log n) where n is the number of items in the list. The two loops are O(n) and adding/removing from a heap is O (log n). Inserting/removing from an array is O(n). | ||
| # Space Complexity: O(n) where n is the number of items in the list because you are creating a new heap that needs to store n number of items. | ||
| def heapsort(list) | ||
| heap = MinHeap.new | ||
| counter = list.length | ||
|
|
||
| # Remove each item from array and add to heap | ||
| counter.times do | ||
| node = list.pop | ||
| heap.add(node) | ||
| end | ||
|
|
||
| # Remove each item from heap and add back to array | ||
| counter.times do | ||
| element = heap.remove | ||
| list.push(element) | ||
| end | ||
|
|
||
| return list | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,26 +8,32 @@ def initialize(key, value) | |
| end | ||
|
|
||
| class MinHeap | ||
|
|
||
| def initialize | ||
| @store = [] | ||
| end | ||
|
|
||
| # This method adds a HeapNode instance to the heap | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(log n) where n is the number of elements in the heap | ||
| # Space Complexity: O(1) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| def add(key, value = key) | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| new_node = HeapNode.new(key, value) | ||
| @store << new_node | ||
|
|
||
| return if @store.length < 2 | ||
| heap_up(@store.length - 1) | ||
| end | ||
|
|
||
| # This method removes and returns an element from the heap | ||
| # maintaining the heap structure | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(log n) where n is the number of elements in the heap | ||
| # Space Complexity: O(1) | ||
| def remove() | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| end | ||
| swap(0, @store.length - 1) | ||
| root_value = @store.pop.value | ||
|
|
||
| heap_down(0) | ||
| return root_value | ||
| end | ||
|
|
||
| # Used for Testing | ||
| def to_s | ||
|
|
@@ -39,33 +45,55 @@ def to_s | |
| end | ||
|
|
||
| output += @store.last.value + "]" | ||
|
|
||
| return output | ||
| end | ||
|
|
||
| # This method returns true if the heap is empty | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) where n is the number of elements in the array | ||
| # Space complexity: O(1) | ||
| def empty? | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| return @store.length == 0 | ||
| end | ||
|
|
||
| private | ||
|
|
||
| # This helper method takes an index and | ||
| # moves it up the heap, if it is less than it's parent node. | ||
| # It could be **very** helpful for the add method. | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(log n) where n is the number of elements in the heap | ||
| # Space complexity: O(1) | ||
| def heap_up(index) | ||
|
|
||
| return if index == 0 | ||
| parent_index = (index - 1) / 2 | ||
| if @store[parent_index].key > @store[index].key | ||
| swap(parent_index, index) | ||
| return heap_up(parent_index) | ||
| else | ||
| return | ||
| end | ||
| end | ||
|
|
||
| # This helper method takes an index and | ||
| # This helper method takes an index and | ||
| # moves it up the heap if it's smaller | ||
| # than it's parent node. | ||
| def heap_down(index) | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| left_child_i = index * 2 + 1 | ||
| right_child_i = index * 2 + 2 | ||
| return if @store[left_child_i] == nil | ||
|
|
||
| # Find smaller child. | ||
| smaller_child_i = left_child_i | ||
| if @store[right_child_i] != nil | ||
| smaller_child_i = (@store[left_child_i].key <= @store[right_child_i].key) ? left_child_i : right_child_i | ||
| end | ||
|
|
||
| if @store[index].key > @store[smaller_child_i].key | ||
| swap(index, smaller_child_i) | ||
| return heap_down(smaller_child_i) | ||
| else | ||
| return | ||
| end | ||
| end | ||
|
|
||
| # If you want a swap method... you're welcome | ||
|
|
@@ -74,4 +102,4 @@ def swap(index_1, index_2) | |
| @store[index_1] = @store[index_2] | ||
| @store[index_2] = temp | ||
| end | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍