Maria-W #35
Open
Maria-W #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Oct 1, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
You have some issues on nth_from_end, but otherwise you hit the learning goals here. Nice work
Comment on lines
209
to
228
| def find_nth_from_end(n) | ||
| raise NotImplementedError | ||
| #raise NotImplementedError | ||
| current = @head | ||
| index = 0 | ||
|
|
||
| while current != nil && index != n | ||
| current = current.next | ||
| index += 1 | ||
|
|
||
| if current == nil | ||
| return nil | ||
| end | ||
|
|
||
| new_current = @head | ||
| while current.next != nil | ||
| current = current.next | ||
| new_current = new_current.next | ||
| end | ||
| return new_current.data | ||
| end |
There was a problem hiding this comment.
A couple of things:
- Your indentation is off here.
- You are missing an
end - Even beyond that, it's not working because on empty lists or lists shorter than what's given
new_currentmay end up beingnil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry is a little late, catching up