Ports - Faiza #16
Open
Ports - Faiza #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AngelaOh
suggested changes
Jun 11, 2019
AngelaOh
left a comment
AngelaOh
left a comment
There was a problem hiding this comment.
Great work on nesting components and passing data through props!
| }); | ||
| return ( | ||
| <section> | ||
| {mappedTimeline} |
There was a problem hiding this comment.
I like how your variable names are clear and easy to follow the logic with!
src/components/TimelineEvent.js
Outdated
| <li> | ||
| <p className="event-style">{props.person}</p> | ||
| <p className="event-style">{props.status}</p> | ||
| <p className="event-style">{props.timeStamp}</p> |
There was a problem hiding this comment.
Where are you incorporating the Timestamp.js file?
| <main className="App-main"> | ||
| <ul> | ||
|
|
||
| <Timeline eventProps={timelineData.events}/> |
There was a problem hiding this comment.
I love how you pass through the data here so you can manipulate it in more nested components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Timeline
Congratulations! You're submitting your assignment!
Comprehension Questions