ports - sav #4
Open
ports - sav #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyriamWD
reviewed
Jun 11, 2019
MyriamWD
left a comment
MyriamWD
left a comment
There was a problem hiding this comment.
Hi Sav,
Great job! Your code is very readable and you use semantic HTML in all the components. I like that you implemented CSS selectors to style the web-app.
| <h1 className="App-title">Super Awesome Timeline</h1> | ||
| </header> | ||
| <main className="App-main"> | ||
| <Timeline events={timelineObjects} /> |
There was a problem hiding this comment.
Nice work passing the prop to the Timeline component
| <Timestamp time={prop.time} /> | ||
| </div> | ||
| </section> | ||
| ); |
There was a problem hiding this comment.
Great use of semantic HTML on this component 👍
| person: timelineObject.person, | ||
| status: timelineObject.status, | ||
| }; | ||
| }); |
There was a problem hiding this comment.
You might be able to pass the props to Timeline without mapping the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Timeline
Congratulations! You're submitting your assignment!
Comprehension Questions