Ports - Sopheary #16
Open
Ports - Sopheary #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 5, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well done, you hit the major learning goals here. The only big issue I see is that you didn't account for the system stack taking up memory in terms of your space complexity.
Remember if you're doing recursion the stack does take up memory space.
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(1) |
There was a problem hiding this comment.
Actually since you're doing a recursive solution the system stack will be of size O(log n) if the tree is balanced and O(n) otherwise.
Also your time complexity will be the same.
| # Space Complexity: | ||
| # Time Complexity: O(n) where n is the number of nodes | ||
| # Space Complexity: O(n) where is is the length of the tree | ||
| def bfs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.