Faiza A. #17
Open
Faiza A. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 5, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
You got almost everything done. However you didn't list the Big-O of each method and you didn't get height done. Otherwise nice work!
Take a look at my comments and let me know what questions you have.
| @root = nil | ||
| end | ||
|
|
||
| # Time Complexity: |
| # Space Complexity: | ||
| def height | ||
| raise NotImplementedError | ||
| def height(current = @root, array) |
There was a problem hiding this comment.
The height of a tree at any node will be the max height of the left subtree compared to the right subtree plus one.
Does that help?
Remember if a current is nil the height is 0.
| # Space Complexity: | ||
| def bfs | ||
| raise NotImplementedError | ||
| def bfs(current = @root, array = []) |
There was a problem hiding this comment.
For this you'll need a Queue, which we'll talk about in class a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.