Savannah #18
Open
Savannah #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 5, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well done, you hit the learning goals here. Do look at my comments on Big-O. I liked the helper methods you wrote and how you did the height methods. Great work!
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(log(n)) where n is the number of nodes | ||
| # Space Complexity: O(1) |
There was a problem hiding this comment.
Remember since you're doing this recursively, the system stack will allocate space for each recursive call.
So if the tree is balanced the space complexity is O(log n), if it's widely unbalanced O(n). The same also applies to time complexity.
| return 0 if !node | ||
| right = longest_tree_path(node.right) | ||
| left = longest_tree_path(node.left) | ||
| return [right, left].max + 1 |
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(n) where n is the number of nodes | ||
| # Space Complexity: O(n) |
There was a problem hiding this comment.
The space complexity will be O(n) if the tree is unbalanced (due to the system stack) or O(log n) if the tree is balanced.
| # Space Complexity: | ||
| # Time Complexity: O(n) where n is the number of nodes | ||
| # Space Complexity: O(n) "" | ||
| def bfs |
| end | ||
| end | ||
|
|
||
| describe "hieght" do |
There was a problem hiding this comment.
Nice, I will use these for C12, if that's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.