Margaret #22
Open
Margaret #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 10, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you you can skip tests on the extra breadth-first-search if it's not done. You did hit the learning goals. Take a look at my comments. I think you have some issues with space complexity. If you have questions let me know via Slack.
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(log n) if it is balanced, O(n) if it is not | ||
| # Space Complexity: Constant |
There was a problem hiding this comment.
Actually since add_helper is recursive the space complexity will be O(log n) if the tree is balanced and O(n) if it's not due to the function call stack.
| def height | ||
| raise NotImplementedError | ||
| # Time Complexity:O(n) | ||
| # Space Complexity:O(n) |
There was a problem hiding this comment.
Space complexity would be O(n) if the tree is widely unbalanced, but O(log n) if it is balanced.
| # Time Complexity: | ||
| # Space Complexity: | ||
| # Time Complexity: O(n) | ||
| # Space Complexity:O(log n) |
There was a problem hiding this comment.
Since you are building an array in this example, it would be O(n)
Same for all the traversals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.