Conversation
CheezItMan
reviewed
Feb 23, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit most of the learning goals here. Not bad. Take a look at my comments and let me know if you have questions. The methods you have written all work, except for delete and you've demonstrated an understanding of how to implement a Linked List, but you still have some things to work on. Take a look at my suggestions and let me know what questions you have.
| @@ -19,54 +19,154 @@ def initialize | |||
| # method to add a new node with the specific data value in the linked list | |||
| # insert the new node at the beginning of the linked list | |||
| def add_first(value) | |||
|
|
||
| # method to find if the linked list contains a node with specified value | ||
| # returns true if found, false otherwise | ||
| def search(value) |
|
|
||
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
|
|
||
| # method to return the min value in the linked list | ||
| # returns the data value and not the node | ||
| def find_min |
| end | ||
|
|
||
| # method that returns the length of the singly linked list | ||
| def length |
| end | ||
|
|
||
| until current == nil | ||
| if current.next.data == value |
There was a problem hiding this comment.
Suggested change
| if current.next.data == value | |
| if !current.next.nil? && current.next.data == value |
| end | ||
|
|
||
| # method to delete the first node found with specified value | ||
| def delete(value) |
| end | ||
|
|
||
| # method that inserts a given value as a new last node in the linked list | ||
| def add_last(value) |
|
|
||
| # method that returns the value of the last node in the linked list | ||
| # returns nil if the linked list is empty | ||
| def get_last |
|
|
||
| until current == nil | ||
| if current.next.data == value | ||
| current.next == current.next.next |
There was a problem hiding this comment.
Small bug here
Suggested change
| current.next == current.next.next | |
| current.next = current.next.next |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.