Open
Conversation
CheezItMan
reviewed
Feb 23, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit all the learning goals here. Well done. I really like how you worked to implement the DoublyLinked list. Take a look at my comments and let me know what questions you have. You put together a lot of really elegant code here, it was hard for me to find things to comment on. Impressive!
| class DoublyLinkedList | ||
| def initialize | ||
| @head = nil | ||
| @tail = nil |
There was a problem hiding this comment.
Great idea to have a @tail attribute!
| # raise NotImplementedError | ||
| end | ||
|
|
||
| def add_first(value) |
| @size += 1 | ||
| end | ||
|
|
||
| def add_last(value) |
| @size += 1 | ||
| end | ||
|
|
||
| def get_first |
|
|
||
| def get_last | ||
| return @tail.data if @tail | ||
| return @tail |
There was a problem hiding this comment.
This method works, but if @tail is nil, I suggest explicitly returning nil here.
Suggested change
| return @tail | |
| return nil |
| # Additional Exercises | ||
| # returns the value in the first node | ||
| # returns nil if the list is empty | ||
| def get_first |
| end | ||
|
|
||
| # method that inserts a given value as a new last node in the linked list | ||
| def add_last(value) |
|
|
||
| # method that returns the value of the last node in the linked list | ||
| # returns nil if the linked list is empty | ||
| def get_last |
| if last_node | ||
| return last_node.data | ||
| else | ||
| return last_node |
There was a problem hiding this comment.
Suggested change
| return last_node | |
| return nil | |
|
|
||
| # method to insert a new node with specific data value, assuming the linked | ||
| # list is sorted in ascending order | ||
| def insert_ascending(value) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.