Open
Conversation
CheezItMan
reviewed
Feb 23, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
You did pretty well with what you got implemented. Several methods remain unfinished, but what is done works pretty well. Take a look at my comments and let me know any questions you have.
| @@ -19,43 +19,97 @@ def initialize | |||
| # method to add a new node with the specific data value in the linked list | |||
| # insert the new node at the beginning of the linked list | |||
| def add_first(value) | |||
|
|
||
| # method to find if the linked list contains a node with specified value | ||
| # returns true if found, false otherwise | ||
| def search(value) |
| else | ||
| current = current.next | ||
| end | ||
| end |
There was a problem hiding this comment.
Just for readability I suggest returning false when you can't find it.
Suggested change
| end | |
| end | |
| return false |
|
|
||
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max |
|
|
||
| # method to return the min value in the linked list | ||
| # returns the data value and not the node | ||
| def find_min |
|
|
||
|
|
||
| # method that returns the length of the singly linked list | ||
| def length |
| # method that returns the value at a given index in the linked list | ||
| # index count starts at 0 | ||
| # returns nil if there are fewer nodes in the linked list than the index value | ||
| def get_at_index(index) |
| while current | ||
| linked_list += "#{current.data}" | ||
| current = current.next | ||
| end |
There was a problem hiding this comment.
Suggested change
| end | |
| end | |
| return linked_list |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.