forked from AdaGold/string-manipulation-practice
-
Notifications
You must be signed in to change notification settings - Fork 48
Branches - Diana Han #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dhan0406
wants to merge
5
commits into
Ada-C12:master
Choose a base branch
from
dhan0406:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
00e41c8
passed unit tests for #sort by length method
dhan0406 c949f4d
able to reverse the WHOLE string, not just by each word
dhan0406 6e309fc
unable to pass tests for #reverse_sentence method
dhan0406 3237d0a
removed sandbox.rb
dhan0406 8c50419
worked on reverse_sentence method and all tests now pass
dhan0406 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,22 @@ | ||
| # A method to reverse the words in a sentence, in place. | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def reverse_sentence(my_sentence) | ||
| raise NotImplementedError | ||
|
|
||
| if my_sentence == nil | ||
| return nil | ||
| elsif | ||
| my_sentence == "" | ||
| return "" | ||
| end | ||
|
|
||
| array = my_sentence.split(/(\S*|\s*)/) # Split by each word and each space | ||
| i = 0 | ||
|
|
||
| array.each do |match| | ||
| position = -i + my_sentence.length - match.length | ||
|
|
||
| my_sentence[position...position+match.length] = match | ||
| i += match.length | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,25 @@ | ||
| # A method which will return an array of the words in the string | ||
| # sorted by the length of the word. | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(n^2) | ||
| # Space complexity: O(n) | ||
|
Comment on lines
+3
to
+4
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct |
||
|
|
||
| def sort_by_length(my_sentence) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice bubblesort |
||
| raise NotImplementedError, "Method not implemented" | ||
| array = my_sentence.split | ||
| length = array.length | ||
| i = 0 | ||
|
|
||
| while i < length-1 | ||
| j = 0 | ||
| while j < length-i-1 | ||
| if array[j].length > array[j+1].length # compares the length of each word | ||
| temp = array[j] | ||
| array[j] = array[j+1] | ||
| array[j+1] = temp | ||
| end | ||
| j += 1 | ||
| end | ||
| i += 1 | ||
| end | ||
|
|
||
| return array | ||
| end | ||
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is making another array causing O(n) space complexity. You were asked to do the reverse in place.