Open
Conversation
CheezItMan
reviewed
Feb 27, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Really nice work, you hit all the learning goals here. Very elegantly written code. Well done! Take a look at my comments on delete and let me know if you have questions.
Comment on lines
+48
to
50
| # Time Complexity: O(logn) in best case | ||
| # Space Complexity: O(1) | ||
| def find(key) |
Comment on lines
+19
to
21
| # Time Complexity: O(logn) in best case | ||
| # Space Complexity: O(1) | ||
| def add(key, value) |
Comment on lines
+59
to
61
| # Time Complexity: O(n) with n is the number of nodes in the tree | ||
| # Space Complexity: O(n) | ||
| def inorder |
| return list | ||
| end | ||
|
|
||
| def preorder |
| return list | ||
| end | ||
|
|
||
| def postorder |
Comment on lines
+130
to
+132
| # Time Complexity: O(n) with n is the number of nodes in the tree | ||
| # Space Complexity: O(logn) which is also the height of the tree. | ||
| def height_helper(current_node, level = 0) |
Comment on lines
+143
to
145
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def bfs |
CheezItMan
approved these changes
Feb 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.