Open
Conversation
CheezItMan
reviewed
Feb 27, 2020
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit the basic learning goals, with some issues on space/time complexity. Check out my comments and let me know if you have any questions.
lib/tree.rb
Outdated
Comment on lines
19
to
21
| # Time Complexity: | ||
| # Space Complexity: | ||
| def add(key, value) |
lib/tree.rb
Outdated
Comment on lines
42
to
44
| # Time Complexity: | ||
| # Space Complexity: | ||
| def find(key) |
lib/tree.rb
Outdated
Comment on lines
63
to
65
| # Time Complexity: | ||
| # Space Complexity: | ||
| def inorder |
There was a problem hiding this comment.
Time & space complexity?
Otherwise 👍
lib/tree.rb
Outdated
Comment on lines
77
to
79
| # Time Complexity: | ||
| # Space Complexity: | ||
| def preorder |
There was a problem hiding this comment.
Time & space complexity?
Otherwise 👍
lib/tree.rb
Outdated
Comment on lines
91
to
93
| # Time Complexity: | ||
| # Space Complexity: | ||
| def postorder |
There was a problem hiding this comment.
Time & space complexity?
Otherwise 👍
lib/tree.rb
Outdated
Comment on lines
105
to
107
| # Time Complexity: | ||
| # Space Complexity: | ||
| def height |
There was a problem hiding this comment.
Time & space complexity?
Otherwise 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.