Breakout Room 9 - Implementing Mad Libs Generator#10
Open
anselrognlie wants to merge 1 commit intomainfrom
Open
Breakout Room 9 - Implementing Mad Libs Generator#10anselrognlie wants to merge 1 commit intomainfrom
anselrognlie wants to merge 1 commit intomainfrom
Conversation
FloritaZhao
reviewed
Apr 21, 2025
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
Collaborator
There was a problem hiding this comment.
consider using "#" instead of //
FloritaZhao
reviewed
Apr 21, 2025
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): |
Collaborator
There was a problem hiding this comment.
consider using "for _ in range(10)", so you don't have to manage extra loop variable
FloritaZhao
reviewed
Apr 21, 2025
| third_noun = input("Choose a noun: ") | ||
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) |
Collaborator
There was a problem hiding this comment.
consider using f string in the print statement
FloritaZhao
reviewed
Apr 21, 2025
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") |
Collaborator
There was a problem hiding this comment.
typo - it should be second_noun, make the spelling consistent
FloritaZhao
reviewed
Apr 21, 2025
Collaborator
FloritaZhao
left a comment
FloritaZhao
left a comment
There was a problem hiding this comment.
consider applying DRY principal in your logic structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.