Breakout Room 10 - Implementing Mad Libs Generator#11
Breakout Room 10 - Implementing Mad Libs Generator#11anselrognlie wants to merge 1 commit intomainfrom
Conversation
florasmile
left a comment
florasmile
left a comment
There was a problem hiding this comment.
Looks good in general, clear logic. Comments are mostly about using f-strings and the loop conditions, and several syntax issues.
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): |
There was a problem hiding this comment.
Double check the exit condition for while loop and make sure user can create 10 stories.
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") |
There was a problem hiding this comment.
Double check the spelling "seond_noun" (possible typo)
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") |
There was a problem hiding this comment.
Consider using f string for integrating variables with strings and adding spaces between words.
| print ("For a duck may be somebody's", seond_noun,",") | ||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () |
There was a problem hiding this comment.
Consider removing this line if print() has no contents?
There was a problem hiding this comment.
Line 2, 5, 12, 22: consider using # for comments instead of “//”
| noun = input("Choose a noun: ") | ||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") | ||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Consider if users enter an invalid input, such as empty input, noun instead of plural noun, a noun instead of adjective.. How would the code handle situations like that?
3 participants
No description provided.