Breakout Room 14 - Implementing Mad Libs Generator#15
Open
anselrognlie wants to merge 1 commit intomainfrom
Open
Breakout Room 14 - Implementing Mad Libs Generator#15anselrognlie wants to merge 1 commit intomainfrom
anselrognlie wants to merge 1 commit intomainfrom
Conversation
DanaMJZ
reviewed
Apr 21, 2025
Collaborator
DanaMJZ
left a comment
DanaMJZ
left a comment
There was a problem hiding this comment.
Looks good overall. please consider the changes mentioned.
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") |
Collaborator
There was a problem hiding this comment.
Please fix spelling error ; seond_noun is typo. it should be second_noun.
| third_noun = input("Choose a noun: ") | ||
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) |
Collaborator
There was a problem hiding this comment.
Please consider python style code PEP8.
Suggested change
| print ("Be kind to your",noun,"- footed", plural_noun) | |
| print (f"Be kind to your {noun}- footed {plural_noun}") |
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") | ||
| print ("Be kind to your",plural_noun,"in",place) |
Collaborator
There was a problem hiding this comment.
Please follow PEP8 style mentioned previously.
Comment on lines
+17
to
+19
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
| print ("You may think that is this the",third_noun,",") |
Collaborator
There was a problem hiding this comment.
Please follow PEP8 style mentioned previously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.