Breakout Room 2 - Implementing Mad Libs Generator#3
Open
anselrognlie wants to merge 1 commit intomainfrom
Open
Breakout Room 2 - Implementing Mad Libs Generator#3anselrognlie wants to merge 1 commit intomainfrom
anselrognlie wants to merge 1 commit intomainfrom
Conversation
Collaborator
malikelmessiry
left a comment
malikelmessiry
left a comment
There was a problem hiding this comment.
Great work overall! Please check out my comments for revision.
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): |
Collaborator
There was a problem hiding this comment.
Consider changing the loop number.
Suggested change
| while (loop < 9): | |
| while (loop < 11): |
| // All the questions that the program asks the user | ||
| noun = input("Choose a noun: ") | ||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") |
Collaborator
There was a problem hiding this comment.
Consider staying consistent
Suggested change
| second_noun = input("Choose a noun: ") | |
| second_noun = input("Choose a second noun: ") |
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") |
Collaborator
There was a problem hiding this comment.
make sure spelling is accurate to call the second noun
| print () | ||
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") |
Collaborator
There was a problem hiding this comment.
Consider DRYing your code by using only one print function
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" | ||
| loop = loop + 1 |
Collaborator
There was a problem hiding this comment.
Suggested change
| loop = loop + 1 | |
| loop += 1 |
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
Collaborator
There was a problem hiding this comment.
Don't forget to make this a function!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.