Skip to content

Breakout Room 4 - Implementing Mad Libs Generator#5

Open
anselrognlie wants to merge 1 commit intomainfrom
Breakout-Room-4
Open

Breakout Room 4 - Implementing Mad Libs Generator#5
anselrognlie wants to merge 1 commit intomainfrom
Breakout-Room-4

Conversation

@anselrognlie
Copy link

No description provided.

noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency consider using "Choose" instead of "Name"

Suggested change
place = input("Name a place: ")
place = input("Choose a place: ")

// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo.

Suggested change
print ("For a duck may be somebody's", seond_noun,",")
print ("For a duck may be somebody's", second_noun,",")

// All the questions that the program asks the user
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add details to the input, we need to clarify that this is the second noun:
input("Choose a second noun: ")

// All the questions that the program asks the user
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
second_noun = input("Choose a noun: ")
second_noun = input("Choose a second noun: ")

second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
third_noun = input("Choose a noun: ")
third_noun = input("Choose a third noun: ")

print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small mix-up in the syntax

Suggested change
print ("You may think that is this the",third_noun,",")
print("You may think that this is the " + third_noun + ",")

Copy link
Collaborator

@TatyanaA90 TatyanaA90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start on building out the story generator! To fully meet the project requirements, the code should include at least two test cases that check the functionality and formatting of the output

Comment on lines +3 to +4
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will only loop 8 times (from 1 to 8), not 10 — consider using while loop <= 10 or range(10)

print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small mix-up in the syntax

Suggested change
print ("Be kind to your",plural_noun,"in",place)
print ("Be kind to your", plural_noun, "in the", place + ",")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants