Breakout Room 6 - Implementing Mad Libs Generator#7
Breakout Room 6 - Implementing Mad Libs Generator#7anselrognlie wants to merge 1 commit intomainfrom
Conversation
greenslippers
left a comment
There was a problem hiding this comment.
Good work overall. But there are some places that need your attention. Please take a look at the line by line comments.
| // All the questions that the program asks the user | ||
| noun = input("Choose a noun: ") | ||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Consider adding "second" for clarity:
| second_noun = input("Choose a noun: ") | |
| second_noun = input("Choose a second noun: ") |
| second_noun = input("Choose a noun: ") | ||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Consider adding "third" for clarity:
| third_noun = input("Choose a noun: ") | |
| third_noun = input("Choose a third noun: ") |
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") |
There was a problem hiding this comment.
Typo in seonc_noun:
| print ("For a duck may be somebody's", seond_noun,",") | |
| print ("For a duck may be somebody's", second_noun,",") |
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
There was a problem hiding this comment.
A quick note: in Python // isn't valid for comments. Replace it with #:
| //Loop back to this point once code finishes | |
| /# Loop back to this point once code finishes |
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): | ||
| // All the questions that the program asks the user |
There was a problem hiding this comment.
See our comment for line 2:
| // All the questions that the program asks the user | |
| # All the questions that the program asks the user |
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") | ||
| // Displays the story based on the users input |
There was a problem hiding this comment.
See our comment for the line 2:
| // Displays the story based on the users input | |
| # Displays the story based on the users input |
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" |
There was a problem hiding this comment.
See our comment for the line 2:
| // Loop back to "loop = 1" | |
| # Loop back to "loop = 1" |
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" | ||
| loop = loop + 1 |
There was a problem hiding this comment.
Consider simplifying this line to loop += 1:
| loop = loop + 1 | |
| loop += 1 |
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
| loop = 1 | ||
| while (loop < 9): |
There was a problem hiding this comment.
Suggest to change to loop <= 10 to implement the requirements:
| while (loop < 9): | |
| while (loop <= 10): |
| print ("For a duck may be somebody's", seond_noun,",") | ||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () |
There was a problem hiding this comment.
Consider deleting the line for consistency:
| print () |
No description provided.