Skip to content

Breakout Room 6 - Implementing Mad Libs Generator#7

Open
anselrognlie wants to merge 1 commit intomainfrom
Breakout-Room-6
Open

Breakout Room 6 - Implementing Mad Libs Generator#7
anselrognlie wants to merge 1 commit intomainfrom
Breakout-Room-6

Conversation

@anselrognlie
Copy link

No description provided.

Copy link
Collaborator

@greenslippers greenslippers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work overall. But there are some places that need your attention. Please take a look at the line by line comments.

// All the questions that the program asks the user
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding "second" for clarity:

Suggested change
second_noun = input("Choose a noun: ")
second_noun = input("Choose a second noun: ")

second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding "third" for clarity:

Suggested change
third_noun = input("Choose a noun: ")
third_noun = input("Choose a third noun: ")

// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in seonc_noun:

Suggested change
print ("For a duck may be somebody's", seond_noun,",")
print ("For a duck may be somebody's", second_noun,",")

@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick note: in Python // isn't valid for comments. Replace it with #:

Suggested change
//Loop back to this point once code finishes
/# Loop back to this point once code finishes

//Loop back to this point once code finishes
loop = 1
while (loop < 9):
// All the questions that the program asks the user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See our comment for line 2:

Suggested change
// All the questions that the program asks the user
# All the questions that the program asks the user

place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
// Displays the story based on the users input
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See our comment for the line 2:

Suggested change
// Displays the story based on the users input
# Displays the story based on the users input

print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See our comment for the line 2:

Suggested change
// Loop back to "loop = 1"
# Loop back to "loop = 1"

print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
loop = loop + 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider simplifying this line to loop += 1:

Suggested change
loop = loop + 1
loop += 1

#Mad Libs Generator Project
//Loop back to this point once code finishes
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to change to loop <= 10 to implement the requirements:

Suggested change
while (loop < 9):
while (loop <= 10):

print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider deleting the line for consistency:

Suggested change
print ()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants