Breakout Room 7 - Implementing Mad Libs Generator#8
Breakout Room 7 - Implementing Mad Libs Generator#8anselrognlie wants to merge 1 commit intomainfrom
Conversation
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" | ||
| loop = loop + 1 |
There was a problem hiding this comment.
Consider writing a test where the user input is empty, or not a string value, as well as another one with valid user inputs
smilesmilejin
left a comment
smilesmilejin
left a comment
There was a problem hiding this comment.
Great work! I have left some comments.
| loop = 1 | ||
| while (loop < 9): |
There was a problem hiding this comment.
Consider the number of iterations needed for the while loop. Here are some suggestions to ensure it runs 10 times to generate 10 stories:
loop = 0
while (loop < 10):
There was a problem hiding this comment.
This looks really good! I did notice a few bugs:
-
use # instead of // on line 1 and line 5
-
this should be a while loop that looks like this while loop < 10:
-
typo on line 13. currently, it's seond_noun, but it should be second_noun
-
loop only runs 9 times instead of 10. should update that to meet the requirements of the project.
5 participants
No description provided.