Skip to content

DragonFly Dennif Portilla#26

Open
dniph wants to merge 5 commits intoAda-C23:mainfrom
dniph:main
Open

DragonFly Dennif Portilla#26
dniph wants to merge 5 commits intoAda-C23:mainfrom
dniph:main

Conversation

@dniph
Copy link

@dniph dniph commented Jun 16, 2025

No description provided.

Copy link

@yangashley yangashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on react-chatlog!

return (
<div id="App">
<header>
<h1>Application title</h1>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An element missing from your project is the header "Chat Between X and Y". Here you have "Application Title".

@dniph How would you create a header that reflects the screenshot below? It can be done by hardcoding the string in the h1 tag, but I'm wondering how would you programmatically get the names of the participants in the chat?

Please respond to this comment with your answer, thank you!

image

import chat from './data/messages.json';

const App = () => {
const [chatMessages, setChatMessages] = useState(chat);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

const toggleLike = (id) => {
const updatedMessages = chatMessages.map((entry) => {
if (entry.id === id) {
return { ...entry, liked: !entry.liked };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We showed this approach in class, but technically, we're mixing a few responsibilities here. rather than this function needing to know how to change the liked status itself, we could move this update logic to a helper function. This would better mirror how we eventually update records when there's an API call involved.

In this project, our messages are very simple objects, but if we had more involved operations, it could be worthwhile to create an actual class with methods to work with them, or at least have a set of dedicated helper functions to centralize any such mutation logic.

const [chatMessages, setChatMessages] = useState(chat);

const toggleLike = (id) => {
const updatedMessages = chatMessages.map((entry) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of map here to both handle making a new list so that React sees the message data has changed, and make new data for the clicked message with its like status toggled.

setChatMessages(updatedMessages);
};

const totalLikes = chatMessages.filter((entry) => entry.liked).length;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea to filter down the data to the liked messages and use the list length as the count!

This approach works, but you'll typically see JS devs use reduce to calculate a value like this:

  const calculateTotalLikeCount = (chatData) => {
    return chatData.reduce((acc, chat) => {
      return chat.liked ? acc + 1 : acc;
    }, 0);
  };

<p className="entry-time">Replace with TimeStamp component</p>
<button className="like">🤍</button>
<p>{body}</p>
<TimeStamp time={timeStamp} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job using the provided TimeStamp component

Comment on lines +7 to +9
const handleLikeClick = () => {
onLikeToggle(id);
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments