Conversation
mikellewade
left a comment
mikellewade
left a comment
There was a problem hiding this comment.
Solhee, great job on this project! There is a comment I tagged you in that I would like you to take a moment really consider, the relationship one.
| from .routes.task_routes import bp as task_list_bp | ||
| from .routes.goal_routes import bp as goals_bp |
There was a problem hiding this comment.
Nice! You are following Flask convention to by naming your Blueprints bp and then using as to import them under an alias.
| @@ -1,6 +1,11 @@ | |||
| from dotenv import load_dotenv # loads .env variables into os.environ | |||
| load_dotenv() | |||
There was a problem hiding this comment.
I would move this function call below all of your other imports, there is no need for it to run before them.
| app.register_blueprint(task_list_bp) | ||
| app.register_blueprint(goals_bp) |
|
|
||
| class Goal(db.Model): | ||
| id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) | ||
| title: Mapped[str] |
There was a problem hiding this comment.
Great work using the declarative mapping here! Since we are doing any specific declarations like in id we can simply use Mapped in conjunction with a Python datatype to declare what this column will look like.
| class Goal(db.Model): | ||
| id: Mapped[int] = mapped_column(primary_key=True, autoincrement=True) | ||
| title: Mapped[str] | ||
| tasks: Mapped[list["Task"]] = relationship(back_populates="goal") |
There was a problem hiding this comment.
Perfect! You are making a relationship attribute on the Goal model. This attribute is going to be a list of Task models. You then use relationship with back_populates to tell SQLAlchemy to sync this attribute with relationship attribute called goal on the Task model.
|
|
||
| # Assert | ||
| assert response.status_code == 404 | ||
| assert response_body == {"message": "Task 1 not found"} |
| assert response.status_code == 204 | ||
|
|
||
| query = db.select(Goal).where(Goal.id == 1) | ||
| goal = db.session.scalar(query) | ||
|
|
||
| assert goal.title == "Updated Goal Title" |
There was a problem hiding this comment.
Great job, checking the database to ensure the changes persisted!
|
|
||
| assert goal.title == "Updated Goal Title" | ||
|
|
||
| # DO I NEED TO ADD ANOTHER ASSERTION -- it said 3 |
There was a problem hiding this comment.
You could also check to ensure that nothing changed about the .tasks attribute.
There was a problem hiding this comment.
But I think the two you have there are fine. @ellenjin
| response = client.put("/goals/1", json={ | ||
| "title": "Updated Goal Title" | ||
| }) | ||
| response_body = response.get_json() | ||
|
|
||
| # Assert | ||
| # ---- Complete Assertions Here ---- | ||
| # assertion 1 goes here | ||
| # assertion 2 goes here | ||
| # ---- Complete Assertions Here ---- | ||
| assert response.status_code == 404 | ||
| assert response_body == {"message": "Goal 1 not found"} |
| assert response.status_code == 404 | ||
| assert response_body == {"message": "Goal 1 not found"} | ||
| assert db.session.scalars(db.select(Goal)).all() == [] |
2 participants
No description provided.