Conversation
…ith Postman; passed Wave 1 tests
…d PATCH/mark_complete.
…Implemented nested routes. Updeted models. Passed all tests.
yangashley
reviewed
May 12, 2025
yangashley
left a comment
yangashley
left a comment
There was a problem hiding this comment.
Overall good work on task-list-api. Your tests pass, I was able to run your migrations, and visit the routes you wrote.
I noticed you created a helper function get_models_with_filters, import it to your route files, but didn't get around to using it. Where could you use it in your routes?
There are 2 incomplete tests in test_wave_01.py, please take a moment to complete those and push up your changes.
Let me know if you have questions about my code review comments. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.