Create and Edit Category Bug Fix#21
Open
annaleeherrera wants to merge 11 commits intoAda-C4:masterfrom
Open
Conversation
| class CategoriesController < GroupingController | ||
| # index - inherited | ||
| # show - inherited | ||
| def new |
There was a problem hiding this comment.
Do you need this since the bulk of the work is in the admin?
Author
There was a problem hiding this comment.
Just checked my git status and didn't commit this deletion. Thanks!
There was a problem hiding this comment.
This is still in here - maybe missing another commit?
|
You should not have the db/db_development and db/db_test files in your commits, please delete and add to your gitignore |
features/create_category.feature
Outdated
| And I am logged into the admin panel | ||
|
|
||
| Scenario: Create category | ||
| Given I am a user |
There was a problem hiding this comment.
Do you need this step given the "as a user" step at the beginning?
Author
There was a problem hiding this comment.
This file was also deleted, just had to commit the change. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A blog administrator can now view, create, and edit a category. The bug was preventing a user to successfully access admin categories and to edit and create them. An ID was not being assigned to the category, preventing the new, create, and edit methods in the admin categories controller to run. RSPEC and Cucumber tests passing, some pending.
Challenges: Initially I overlooked that there were separate admin and user sections of the site. I kept getting errors for a missing template when I was editing methods in the admin categories controller, so I started to create new views outside of admin. After closely examining the tests, I realized my mistake and the bugs became easier to fix.