forked from publify/publify
-
Notifications
You must be signed in to change notification settings - Fork 19
New feature - Reverse post :-) #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TammyHer
wants to merge
19
commits into
Ada-C4:master
Choose a base branch
from
TammyHer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
62deca4
trying to write cucuember test...
TammyHer e3f9458
added new rspec test
TammyHer fc57f63
chaned the cucuember file name and some context
TammyHer a6b3df0
so I ran cucuember and it showes me Couldn't find Category without a…
TammyHer f140e34
i have 2 failing tests wohhoo... now time to fix the bug
TammyHer fddd88f
the spec is passing
TammyHer f4b0c33
my rspec and cucumber test are passing
TammyHer e0473a0
starting to write cucuember test for a feature that will revers all t…
TammyHer 8a38f77
removed comment-out tests after reading Kari notes
TammyHer a56c8a3
changed the feature name
TammyHer 430d835
added a reverse option, near the edit and delete
TammyHer 676cb16
hard coded the item id with 2, for test
TammyHer df9d0d4
yess it seems to almost work
TammyHer 890c0b5
it reverse seccufuly succefuly
TammyHer 9408123
so I've just noticed I created a new feature that I didn't have to :(…
TammyHer 25a83d9
the cucuember test is passing. PR and nex feature (the real one)
TammyHer a5b1a2a
added cucuember test
TammyHer b2b7bab
after reading Kari's comment I've changed the each method
TammyHer cfe2958
changed the if statement after reading Kari's comment
TammyHer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| Feature: Add and Edit Category | ||
| As an author | ||
| In order to know what each blog is about | ||
| I want to create categories | ||
|
|
||
| Background: | ||
| Given the blog is set up | ||
| And I am logged into the admin panel | ||
|
|
||
| Scenario: Successfully add category | ||
| When I follow "Categories" | ||
| And I should be on the new category page | ||
| When I fill in "Name" with "Baby Stuff" | ||
| And I press "Save" | ||
| Then I should be on the new category page | ||
| And I should see "Baby Stuff" | ||
|
|
||
|
|
||
| Scenario: Successfully edit a category | ||
| When I follow "Categories" | ||
| When I follow "Edit" | ||
| And I fill in "Name" with "Mommy Stuff" | ||
| And I press "Save" | ||
| Then I should be on the new category page | ||
| And I should see "Mommy Stuff" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| Feature: Merge Articles | ||
| As a the admin | ||
| In order to condense similar articles | ||
| I want to be able to merge articles | ||
|
|
||
| Background: | ||
| Given the blog is set up | ||
| And I am logged into the admin panel | ||
|
|
||
| Scenario: Successfully merge articles | ||
| Given I am on the new article page | ||
| When I fill in "article_title" with "Merge me!" | ||
| And I fill in "article__body_and_extended_editor" with "I like tomato soup" | ||
| And I press "Publish" | ||
| Then I should be on the admin content page | ||
| When I go to the home page | ||
| Then I should see "Hello World!" | ||
| And I should see "Merge me!" | ||
| When I go to the new article page | ||
| And I fill in "merge" with "1" | ||
| And I follow "Merge" | ||
| Then I should be on the new article page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| Feature: Reverse Article | ||
| As an author | ||
| In order to see the world in a different way | ||
| I want to reverse a blog | ||
|
|
||
| Background: | ||
| Given the blog is set up | ||
| And I am logged into the admin panel | ||
|
|
||
| Scenario: Successfully reverse articles | ||
| Given I am on the new article page | ||
| When I fill in "article_title" with "Test" | ||
| And I fill in "article__body_and_extended_editor" with "Pink shirt" | ||
| And I press "Publish" | ||
| Then I should be on the admin content page | ||
| When I follow "Reverse" | ||
| And I follow "Test" | ||
| Then I should see "shirt Pink" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
findmethod will return an error if it cannot find an Article with this ID so I don't think it would get to the next line. Consider using an alternate method to find.