forked from AdaGold/BankAccounts
-
Notifications
You must be signed in to change notification settings - Fork 26
Bank Accounts #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jadevance
wants to merge
22
commits into
Ada-C5:master
Choose a base branch
from
jadevance:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bank Accounts #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les for class account. Defined the skeleton of the class with methods: withdraw money, deposit money and show balance.
…s the new balance. No error handling yet.
…account balance below 0 dollars. Defined method called check_new_account
…f all bank accounts.
…ds can return all owners or a specific owner from the data.
…a structure. self.all and self.find now properly return data requested.
…tead of an array of arrays, now it is an array of hashes with meaningful keys assigned to the data.
…n ways I cannot explain but it makes more sense this way and is easier to access. Tested show_balance, withdraw_money and deposit_money methods and they all work as expected.
… version of accounts.csv) Set a constant called ALLOWED_BALANCE to prevent initial balances of less than 0 from being allowed as savings accoungs.
… is removed with each transaction. If the balance is below 0 the transaction does not happen and no money moves. Used a WITHDRAW_FEE constant to keep track of the fee.
…y calculates interest and adds it to the current balance of the account.
…nctionality is working. Still need to implement checks amd transaction fees for using more than three checks per month.
…now correctly tracked and if the user writes more than three checks per month they will incur an additional fee of . At the end of the month checks can now be reset to 0.
…r 10k but nothing else yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.