Open
Conversation
… once owner has been made
…ake sure it works
…edundantgit add bank_account.rb
…g to which owner id
…ds, and new add_interest method
…and start checking account class with withdraw method
…us fun times, after some refactoring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was really fun. It really drove home the Metz chapters we read about how we should focus on writing code for the tasks at hand and not worry about the changes that will inevitably come, but build methods and classes that will be easy to change. I need to stop trying to see the big picture right away.
This commit (seemingly) tackles all the optionals for all waves, including a functional but very sloppy method for the tricky logic needed in withdraw and deposit logic. Thinking through that was a ton of fun.