forked from AdaGold/BankAccounts
-
Notifications
You must be signed in to change notification settings - Fork 26
Bank Account Project #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jweeber
wants to merge
31
commits into
Ada-C5:master
Choose a base branch
from
jweeber:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…info and owner info. owner hash can be passed in account class via a method
…r arraysand another that allows for searching by id number and displays all info for that acct.
…nce of the account class. also figured out how to convert the date created field into a DateTime objectfrom a string.
…to return all instances is working but might not be what we're supposed to return.
…the self.all class, since this is normally what would be called and there is no need to call anything to import
… shit wasn't even working.
…h to normal vars because otherwise it's really confusing.
… accounts instance method for owner class.
…n id or owner is not found
…lass account. new initialize method for savings account created.
…withdraw method of the account class
…nt to the balance
…ow to inherit it from base class but replace withdrawal fee constant with one in subclass
…aw methods throughout. which actually makes it more readable now so that's cool.
…d of return so that when i super the method in moneymarketaccount class it works. transaction counts not working in deposit method though.
…arketaccount class. also added a method to reset the transaction count.
… back to original.
…timate penny bank.
…rom the csv. moved that to each of the other accounts instead because otherwise it will print out a bajillion times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final bank account project!
All amounts are entered in pennies. I am seriously super proud of my code because I feel like it's pretty self-documenting since I used constants.
Requires these gems: