Skip to content

Conversation

@BlueColorPencils
Copy link

No description provided.

end
full_list += [current.value.to_s]
return p "Size is #{full_list.length}."
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These looks generally good -- however, both methods are creating a side effect of printing something. If you are not asked to print something out, then you don't necessarily want to because it limits how you can use that method in the future.

I would expect that a method with a ? at the end would return a boolean and not print anything out.

I would also expect that a size method would only return a single numerical value and nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants