Jillian's PR for Mood-Analysis #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uestions lead me to beleive maybe I missed the point of the exercise? So, I guess I'd really like to talk this over with someone. I thought I understood, but maybe not.
| ``` | ||
|
|
||
| **think**: Where should we call `strip_punctuation`? Does it matter? Why? | ||
| **think**: Where should we call `strip_punctuation`? Does it matter? Why? We need to call strip_punctuation before we call analyze_mood, because in order for analyze_mood to populate correct results the strings must be stripped of their text. |
There was a problem hiding this comment.
This is true. What I should have asked is "Should you call strip_punctuation inside or outside the analyze_mood method?"
|
You're correct. The solution works, which is always the first step, so good job on that! But you were also correct in that the point of the assignment was to start making some deeper analysis on why we do things in certain ways and to identify when/where hashes are useful (other things too). You were able to identify that your code may be flawed, which is also good. Hopefully my explanations make sense, but regardless, I'll probably ask Jeremy for time to go over this in class with everyone. If not, I'm happy to go through it with you 1-1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've completed the assignment, and the code works, but the last two questions lead me to believe maybe I missed the point of the exercise? So, I guess I'd really like to talk this over with someone. I thought I understood, but maybe not.