Mood Analysis Homework; #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| **think**: Why does 03/13 come out as _sad_ when it should be _happy_? How could we fix this? | ||
| **think**: Why does 03/13 come out as _neutral_ when it should be _happy_? How could we fix this? | ||
|
|
||
| We could look for key words like yesterday and today. Also I'm guessing that yay with an exclamation point won't count as included in the happy array. |
There was a problem hiding this comment.
What does looking for key words like yesterday and today help us? Correct on the ! :)
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sophia Baldonado
I am satisfied with this submission, however I may look into rewriting the overall_mood method because I think it loops through the given array four times and is pretty hard to really understand by just looking at it. I can probably find a solution that only loops through once or twice and is more people friendly to read and understand.