Alma (primary reqs and some w3 optionals)#4
Open
mimyal wants to merge 10 commits intoAda-C6:masterfrom
Open
Conversation
…ithdraw methods to work with csv hash as in their previous format they did not work at all. Made bank_program work again too.
…rket deposits not tested
mimyal
changed the title
mimyal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started a TDD class but in wave 1 and 2 I realized I had no time. My program file is trying to do what that class would have done. I had more time at wave 3 but I didn't know I would have it so instead I tackled the optional at the end.
In withdraw_using_checks I started to wonder what better loops there were than my un-nested if-loops, but I didn't know that any other option was better than mine so I left it.
In MoneyMarkets withdraw-method I had even more if-loops, but as I successfully suspended the account I had no time to revisit because I wanted to have time to fix that. Maybe a case-loop would make more sense here.
I am scared of adding "all that data" in the optionals for wave 1 and 2 so I tinkered with the primary reqs. Have no time to revisit this weekend but it would be good for me.