Theresa's Bank Account

[TheresaManney]

Bank Account

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
Why is it useful to put classes inside modules? What do you think?	It is useful to put classes inside modules because the classes can be different instances of a module. The module can have characteristics that can carry out through classes. I think they are also a good way to organize classes to understand how the classes are communicating and relate to one another.
What is accomplished with raise ArgumentError? What do you think it's doing?	raise ArgumentError is a response to user input error for when we know exactly what the error will be. So instead of the program breaking and showing a terminal type error message, it will not exit the program. It will output an error message to the user that the code designer made and will sometimes even re-prompt the user too depending on the situation.
Why do you think we made the .all & .find methods class methods? Why not instance methods?	We used class methods for .all and .find since they don't deal with specific instances of the class, they are more constant. One that creates an array of all the accounts and one that can find things within the array created in .all.
Why does it make sense to use inheritance for the different types of accounts?	This makes sense because different accounts have similar properties to its parent / super class that can then be utilized in their own class and can also be modified based on being a different account type.
Did the presence of automated tests change the way you thought about the problem? How?	Yes, it forced me to think about what could go wrong if the user were to utilize my code before anything actually goes wrong. This form of testing made me think in a different way too. For instance I noticed that if I thought I would need to use a loop for a test, I would often be in a loop type mindset and would have to swing out of thinking in the form of loops when actually writing my code.

[kariabancroft]

Bank Account

What We're Looking For

Feature	Feedback
Wave 1
All provided tests pass	Yes
Using the appropriate attr_ for instance variables	Yes. Nice job using the optional parameter in the initialize.
Wave 2
All stubbed tests are implemented fully and pass	Yes
Created instances (by calling new) in Account.all	Yes
Used CSV library only in Account.all (not in Account.find)	Yes
Used Account.all to get account list in Account.find	Yes. If you use return inside of your loop on line 41, then you would save yourself processing time. If you find the account as the first account, you shouldn't continue looping through all of the rest of the accounts.
Wave 3
All stubbed tests are implemented fully and pass	Yes. You could DRY the tests up by putting the object instantiation in the before block instead of in each individual test. Nice job using the times for the duplicated logic in the check tests.
Used inheritance in the initialize for both Checking and Savings Accounts (min balance)	Yes - though the min balance logic is duplicated in the savings account. I'm not sure exactly what line 12 is doing in the checking account initialize. Isn't that already happening in the parent class's initialize?
Used inheritance for the withdraw in checking and savings accounts	Yes - halfway. Utilizing super with an adjusted amount in the checking account which is great. The savings account logic is duplicated.
Baseline
Used Git Regularly	Yes. Nice job with frequency and messages.
Answer comprehension questions	Yes. I appreciated your description of how testing has impacted your programming practice.
Extras	Nice job with Owner optional (and tests).
Overall	Nice job. Seems like you got good practice with testing