Queues - Sofia Kim - BankAccounts

[Sofia15]

Bank Account

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
Why is it useful to put classes inside modules? What do you think?	Allows for us to keep all related classes in the same namespace (module).
What is accomplished with raise ArgumentError? What do you think it's doing?	Identifies where errors can be possible and if an error occurs, will either terminate the program or execute the rescue associated with the ArgumentError.
Why do you think we made the .all & .find methods class methods? Why not instance methods?	.all & .find class methods were needed to make the csv file available across all accounts instead of on specific instance.
Why does it make sense to use inheritance for the different types of accounts?	To allow us to utilize and modify instance methods and variables efficiently from the parent class by using 'super' instead creating new methods and variables each time.
Did the presence of automated tests change the way you thought about the problem? How?	Yes. The automated tests have made me think about what would make the program run into errors and what errors I should be considering, including results that are not desired. A program can be great with the proper inputs but we have to also make sure that bad inputs are accounted for in some way as well.

|

[droberts-sea]

Bank Account

What We're Looking For

Feature	Feedback
Wave 1
All provided tests pass	yes
Using the appropriate attr_ for instance variables	yes
Wave 2
All stubbed tests are implemented fully and pass	mostly - see inline comments
Created instances (by calling new) in Account.all	yes
Used CSV library only in Account.all (not in Account.find)	yes
Used Account.all to get account list in Account.find	yes
Wave 3
All stubbed tests are implemented fully and pass	yes
Used inheritance in the initialize for both Checking and Savings Accounts	yes
Used inheritance for the withdraw in checking and savings accounts	yes
Baseline
Used Git Regularly	In the future I would like to see smaller, more frequent commits, with more descriptive commit messages. A good cadence is usually to commit whenever you've written a new test and gotten it passing.
Answer comprehension questions	yes

Great work overall!

[droberts-sea]

In addition to checking that what you got back from Account.find is an account, you should verify that the ID matches what you asked for. As is, find could return any old account and your test would still pass.

[droberts-sea]

Good work on Account.all and Account.find, I feel like this implementation is about as clean as it gets.