Alison's Bank Accounts by AlisonZ · Pull Request #47 · Ada-C7/BankAccounts

AlisonZ · 2017-02-27T19:52:13Z

Bank Account

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
Why is it useful to put classes inside modules? What do you think?	For clarity, to deal with methods in different modules that may share a name, such as all. in the Bank module it can only be accessed in a Bank instance and so another module would not have access to that method
What is accomplished with `raise ArgumentError`? What do you think it's doing?	Lets user know that their input is not correct, can not be handled by the program. It seems like it also breaks out of the method
Why do you think we made the `.all` & `.find` methods class methods? Why not instance methods?	I am still unclear as to why class methods are useful. Is it because they can be used in the savings and checking??
Why does it make sense to use inheritance for the different types of accounts?	So that shared methods can just occur in the superclass and get passed on, share the load, avoid duplication
Did the presence of automated tests change the way you thought about the problem? How?	Not really. They were all things that I would test while building the program, but test them below the code. This is just a different/better way to do that and keep it separate from the coding file.

…antiated

…e working.

…v works for everything but opendate

…e first test

… it worked

… working too

…nt is finished

…draw in account class

…he big brother accounts class and tests are clean; using methods for minimum and fee

…amount

…les in savings account spec that need to be dealt with

…rror/failure free

CheezItMan · 2017-02-28T00:54:20Z

Bank Account

What We're Looking For

Feature	Feedback
Wave 1
All provided tests pass	check
Using the appropriate `attr_` for instance variables	Check
Wave 2
All stubbed tests are implemented fully and pass	Check
Created instances (by calling `new`) in `Account.all`	Check
Used `CSV` library only in `Account.all` (not in `Account.find`)	Check
Used `Account.all` to get account list in `Account.find`	Check, well done!
Wave 3
All stubbed tests are implemented fully and pass	Missing at least one test, left comments in the PR.
Used inheritance in the initialize for both Checking and Savings Accounts (min balance)	Cleverly done!
Used inheritance for the withdraw in checking and savings accounts	Check
Baseline
Used Git Regularly	Pretty regular commit history, nicely done.
Answer comprehension questions	Class Methods: We use class methods for actions that are tied to the entire class and not a specific instance. The `.all` and `.find` were methods used to process all the Accounts and not just a single instance.

Summary

Overall nicely done, the use of methods for fee, etc were a nice way to handle withdrawal using inheritance. You did have some things missing in your tests. Overall nicely done.

CheezItMan

Nicely done overall, a few comments here and there.

CheezItMan · 2017-02-27T22:48:41Z

lib/checking_account.rb

+
+
+        #method which returns 1, so fee for any object in checking account is now 1
+        def fee


Interesting how you used this for the inheritance in Checking & Savings.

CheezItMan · 2017-02-28T00:34:11Z

lib/account.rb

+            raise ArgumentError.new("You need some positive cash flow to open an account") if balance < 0
+            @id = id
+            @balance = balance
+            @opendate = opendate


a more standard name would be @open_date

CheezItMan · 2017-02-28T00:42:46Z

specs/checking_account_spec.rb

+describe "CheckingAccount" do
  describe "#initialize" do
    # Check that a CheckingAccount is in fact a kind of account
    it "Is a kind of Account" do


test for it being an Account?

CheezItMan · 2017-02-28T00:43:36Z

specs/checking_account_spec.rb

+
+        account = Bank::CheckingAccount.new(id, balance)
+        account.withdraw_using_check(amount)
+        account.balance.must_be :<, balance


good use of must_be

CheezItMan · 2017-02-28T00:46:22Z

specs/checking_account_spec.rb


    it "Requires a positive withdrawal amount" do
-      # TODO: Your test code here!
+        id = 116


Where's the attempt to do a negative withdrawal?

CheezItMan · 2017-02-28T00:46:59Z

specs/checking_account_spec.rb

+        amount = 10
+
+        account = Bank::CheckingAccount.new(id, balance)
+        4.times do account.withdraw_using_check(amount) end


Good use of a loop!

AlisonZ added 30 commits February 21, 2017 17:36

sets up initial structure of module and class

b092c16

adds show balance method and verifies that new objects are being inst…

a7faa32

…antiated

working withdraw method, needs to be tested with spec file

8f64dba

withdraw method works and passes tests

9d1ca5b

deposit feature working and passes tests

5d96b68

adds error for negative starting balances and all tests for Wave 1 ar…

66f4bf0

…e working.

phase one features are working

546ff3b

phase one is working and passes all tests

87df7fe

code and tests for self.all are working thanks to chris video

1131b7a

find tests for verifying an account and that the first matches the cs…

ae34958

…v works for everything but opendate

wave one working except for open dates

d24e5e5

there is a new class savings that inherits from account and passes th…

d9f47c4

…e first test

holy cow the initialize works and i just wrote a test before code and…

440ea50

… it worked

transaction fee is working and the test is all green

e84065a

withdraw fee tests and code works

8184e59

not letting withdraws happen if fee would put account under 10; tests…

339a8ca

… working too

holy cow all of the tests and code for savings account work

9030ecf

savings account interest is being tracked and tests all work.

cac59ee

changed interest to a local variable, tests still pass, savings accou…

102fed7

…nt is finished

tests and code working for initializing and fee for withdraw method

e27d6b0

trying to make variables of minimum and fee to share the load of with…

b736ce5

…draw in account class

woohooooooo savings and checking withdraw are inheriting stuff from t…

4fcfd35

…he big brother accounts class and tests are clean; using methods for minimum and fee

withdraw tests all done for checking working

dbfd30d

test for withdraw using check working and new balance is being returned

cb2b142

does not allow to go below -10

5008cf3

doesn't allow to withdraw below -10 and requires a positive withdraw …

3994ad1

…amount

allows three free checks; there are some warnings about unused variab…

760dae0

…les in savings account spec that need to be dealt with

withdraw_using_checks method is a go

3417c20

reset checks method working

88bacf4

all working, no errors.

221f959

AlisonZ added 3 commits February 24, 2017 15:42

adds final forgotten test in savings spec. baseline is finished and e…

744f595

…rror/failure free

managed merge conflict

664da91

submittinh hwk

61f6739

CheezItMan reviewed Feb 28, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alison's Bank Accounts#47

Alison's Bank Accounts#47
AlisonZ wants to merge 33 commits intoAda-C7:masterfrom
AlisonZ:master

AlisonZ commented Feb 27, 2017

Uh oh!

CheezItMan commented Feb 28, 2017

Uh oh!

CheezItMan left a comment

Uh oh!

CheezItMan Feb 27, 2017

Uh oh!

CheezItMan Feb 28, 2017

Uh oh!

CheezItMan Feb 28, 2017 •

edited

Loading

Uh oh!

CheezItMan Feb 28, 2017

Uh oh!

CheezItMan Feb 28, 2017

Uh oh!

CheezItMan Feb 28, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		#method which returns 1, so fee for any object in checking account is now 1
		def fee

Conversation

AlisonZ commented Feb 27, 2017

Bank Account

Comprehension Questions

Uh oh!

CheezItMan commented Feb 28, 2017

Bank Account

What We're Looking For

Summary

Uh oh!

CheezItMan left a comment

Choose a reason for hiding this comment

Uh oh!

CheezItMan Feb 27, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Feb 28, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Feb 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CheezItMan Feb 28, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Feb 28, 2017

Choose a reason for hiding this comment

Uh oh!

CheezItMan Feb 28, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CheezItMan Feb 28, 2017 •

edited

Loading