Skip to content

Conversation

@cecomfort
Copy link

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I first read the api recipe search documentation, keeping an eye out for the information requested by the assignment requirements. I then tested out various searches in a separate ruby file and once I got the info I desired, I drafted a recipe class for my rails application.
Describe your API Wrapper. How did you decide on the methods you created? I knew I needed a general search method to find recipe(s) when given a search term. I realized this method could be applied to both a single recipe search based on the uri and a more generic search based on a user search term. I later added a count results method to facilitate pagination.
Describe an edge case or failure case test you wrote for your API Wrapper. I tested that when no recipes were found, my count_results method would return 0.
Explain how VCR aids in testing an API. Since VCR allows the tests to record HTTP interactions in cassettes that can be replayed as needed, VCR improves the stability and performance of the test suite to be independent of external API code. (This independence is only after the cassette is recorded).
What is the Heroku URL of your deployed application? https://api-muncher-cara.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort?

cecomfort added 23 commits May 3, 2017 11:02
@PilgrimMemoirs
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Well Done
General
Rails fundamentals (RESTful routing, use of named paths) Well Done
Semantic HTML Well Done
Errors are reported to the user Mostly Good - if I change the address of the show page, instead of an error it shows an error with: "page can’t be found No webpage was found for the web address, HTTP ERROR 404" - what could you do to still show your own view with an error message?
API Wrapper to handle the API requests Well Done
Controller testing Well Done
Styling
Foundation Styling for responsive layout Well Done
Search View Well Done
List View Well Done
Show View which opens in a new tab Well Doe
API Features
The App attributes Edaman Well Done
The VCR casettes do not contain the API key ❗️ Hide those keys! Use your environment variables in your cassettes as well.
Overall
Great work completing all the requirements to expectations. The site is also very well styled and easy to navigate, especially with linking the title to the homepage and having a link to the search results on the show pages. Nice touches! Good use of the cassettes for the controller tests, although I do not see any tests for the positive or negative cases for querying a single recipe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants