Skip to content

Conversation

@amb54
Copy link

@amb54 amb54 commented May 10, 2017

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? I created an account at developer.edamam.com and as logged in got information at Recipe Search API Documentation as well as an API key and API id. Postman was used to try out the querying as well as with code in a .rb file.
Describe your API Wrapper. How did you decide on the methods you created? I created two class methods. One called search that for a specific query returns ten (or less) instances of recipes with. Only the recipes uri, label and image is required when a new object is created. The second class method returns all information that a query about a specific recipe (using the information in the uri) have.
Describe an edge case or failure case test you wrote for your API Wrapper. I wrote a test for what is returned given a nonsense query, or a nil query.
Explain how VCR aids in testing an API. A query can "be used over and over again" in the tests, so the tests can be run without risking to use up all free API calls.
What is the Heroku URL of your deployed application? https://amb-recipes.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort? I think this was a good project.

amb54 added 27 commits May 2, 2017 13:59
…t-vcr, webmock, dotenv-rails and simplecov. Updated test_helper for simplecov and VCRconfigure. Added coverage and (dot)env to (dot)gitignore. Created a file (dot)env and added constants for id and key. Updated test_helper with the secretnames. Created a Lib file called edamam_recipe. Created a folder Lib in the folder for tests. In this folder created a file edamam_recipe_test. Generated the recipies_controller.
…fic recipe. Corrected misstake in initializer. Coomented out and moved code that is currently not used. Updated self.search to accept three parameters. Updated self.show.
… self.show. Corresponding updates to edamam_recipe.rb
…nal sites were placed. Added Nutrition facts'
@PilgrimMemoirs
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Well Done
Comprehension questions Well Done
General
Rails fundamentals (RESTful routing, use of named paths)
Semantic HTML Well Done
Errors are reported to the user Well Done
API Wrapper to handle the API requests Well Done
Controller testing Well Done - nice testing of flash message for negative cases.
Styling
Foundation Styling for responsive layout Well Done - good use of the breakpoints
Search View Well Done - Nice touch having the search form on the top nav on every page
List View Nice formatting and styling of information. It's easy to see all the results on that page
Show View which opens in a new tab Well Done
API Features
The App attributes Edaman Well Done
The VCR casettes do not contain the API key Well Done - nice variety of cassettes
Overall
Great lib tests, and using the cassettes
Project meets expectations and demonstrates a solid understanding of using an API, wrapping it's functionality into a wrapper testing it, and creating a custom interface for the provided data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants