Skip to content

Conversation

@janicewilson
Copy link

@janicewilson janicewilson commented May 11, 2017

API Muncher

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How did you go about exploring the Edamam API, how did you try querying the API? Started with Edama's docs and FAQ. Then made good use of Postman.
Describe your API Wrapper. How did you decide on the methods you created? My wrapper is a substitute for the missing Rails model that serves up the data retrieved from the API.
Describe an edge case or failure case test you wrote for your API Wrapper. I served my getRecipe method a fake id to thwart the entire operation.
Explain how VCR aids in testing an API. The first round, the VCR records the API episode when called via a method. The second (and subsequent) round(s), provided the criteria re method, URI and body is a match, the VCR serves up the cassette for replay. This cassette then saves my API count for a rainy day.
What is the Heroku URL of your deployed application? http://chocolatarian.herokuapp.com
Do you have any recommendations on how we could improve this project for the next cohort? More time would be lovely. This would have been a fun one to pimp out and place in the portfolio. I'd also be interested in the topic of caching as my app was hella slow.

@kariabancroft
Copy link

API Muncher

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Yes
General
Rails fundamentals (RESTful routing, use of named paths) Good
Semantic HTML Not really - though I know you're still working through the design aspects
Errors are reported to the user I think the way you're using the flash & redirect if the recipe isn't found (though I don't think you have the flash in your view at all)
API Wrapper to handle the API requests Yes - I think the Recipes controller is using the wrapper only and not the recipe (referring to the require statements)
Controller testing Yes - you have covered most of the major testing across the controller, wrapper and recipe object
Styling
Foundation Styling for responsive layout Not yet
Search View Yes - I like that this is at the top of the listings, though it might be good to have at the top all the time (application view)
List View Good
Show View which opens in a new tab Yes
API Features
The App attributes Edaman Only on the recipe show page- should be on all pages
The VCR casettes do not contain the API key Check
Overall Nice job hitting the major learning goals around using an API. Looking forward to seeing the next phase with foundation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants