Ana Lisa Sutherland - Calculator- Octos#25
Open
The-Beez-Kneez wants to merge 2 commits intoAda-C9:masterfrom
Open
Ana Lisa Sutherland - Calculator- Octos#25The-Beez-Kneez wants to merge 2 commits intoAda-C9:masterfrom
The-Beez-Kneez wants to merge 2 commits intoAda-C9:masterfrom
Conversation
02/07/2018: Almost finished with the calculator assignment for Week 1
02/07/18: Finished and submitting Calculator Assignment for Week 1.
CalculatorWhat We're Looking For
Great job overall! I have a couple of inline comments below that you should check out, but in general I am quite happy with this submission. Keep up the hard work! |
droberts-sea
reviewed
Feb 9, 2018
| #OPTIONAL: ENSURE IT IS ONLY NUMBERS THAT ARE ENTERED | ||
| def req () | ||
| num = gets.chomp | ||
| until num =~ /^[1-9]\d*(\.\d+)?$/ |
There was a problem hiding this comment.
Good use of a regex here to verify user input - way to go above and beyond.
One comment: I'm not so sure about the method name req. This doesn't really tell me what the method does, which will make code that calls it harder to read. I would prefer something more descriptive like read_number.
| command_use = gets.chomp | ||
| until ["add", "+", "subtract", "-","multiply", "*", "divide", "/", "**", "^", "modulo", "%"].include?(command_use) | ||
| puts "Please put a valid command!" | ||
| command_use = gets.chomp |
There was a problem hiding this comment.
It might be good to let the user know what commands are valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
02/07/2018: Almost finished with the calculator assignment for Week 1
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions