(Ampers) Leticia Tran - My Calculator #26
Open
LetiTran wants to merge 2 commits intoAda-C9:masterfrom
Open
Conversation
…al to zero, instead of the two numbers being evaluated if it's equal or less than equal.
CalculatorWhat We're Looking For
|
CheezItMan
reviewed
Feb 10, 2018
| puts "\n" | ||
| print "Number 1: " | ||
| first_num = gets.chomp | ||
| while first_num.match?(/\D/) && !(first_num.match?(/\d\.\d/)) || first_num == "" |
There was a problem hiding this comment.
Nice work trapping user input until they get the put in an acceptable value.
However notice that you repeat this code... makes a good candidate for a method!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calculator
Congratulations! You're submitting your assignment.
Comprehension Questions