Angela, Cara, Dikla, Karinna - pEtsy fEels - Octos #21

karinnainiguez · 2018-04-27T22:54:30Z

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
How did your team break up the work to be done?	We worked on design as a group first. Testing for models and controllers was split up as evenly as possible to work individually. We shared screens and paired for things like oAuth, session, and the cart. We also did a lot of pair programming and debugging together after standups.
How did your team utilize git to collaborate?	We branched off when working individually, and would wait to push to master until we were all ready and had discussed the changes that were made. That usually happened after standups.
What did your group do to try to keep your code DRY while many people collaborated on it?	We created helper methods in the application controller that were used by multiple models. We also removed any controller methods that we felt were redundant or unnecessary.
What was a technical challenge that you faced as a group?	After deployment we realized that browsers see http requests differently than https requests and that was preventing some people from logging in to our site from their computers.
What was a team/personal challenge that you faced as a group?	Designing and creating a cart and what types of relationships would work as a "cart" was really difficult. We decided that instead of pairing or doing it individually, we would share screens among the four of us and talk together through it. It worked well, so we continued to do that with heroku issues that we faced.
What could your team have done better?	We did a good job of testing before we started coding, but then abandoned our tests through the week. It was painful to go back and test existing code. Maybe we could have kept testing while we coded in TDD style to avoid the burnout.
What was your application's ERD? (include a link)	https://www.lucidchart.com/documents/view/7f53f6ef-0162-40f1-b370-bf08fc593e0a/0
What is your Trello URL?	https://trello.com/b/xQMD4GLc/petsy-feels
What is the Heroku URL of your deployed application?	https://petsyfeels.herokuapp.com/

karinna v

yes

kariabancroft · 2018-05-07T19:28:57Z

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	Yes
Answered comprehension questions	Yes
Trello board is created and utilized in project management	Yes - and it looks great. You had distinct tasks and it was clear to me how it was organized and assigned.
Heroku instance is online	Yes
General
Nested routes follow RESTful conventions	Yes
oAuth used for User authentication	Yes
Functionality restricted based on user roles	Yes - you require logging in. But it looks like you're not preventing users from editing other users products. So if I am logged in, I still shouldn't be able to edit another merchants products.
Products can be added and removed from cart	Yes
Users can view past orders	Yes - nice job with the functionality of the order dashboard
Merchants can add, edit and view their products	Yes
Errors are reported to the user	Yes - using models and flash messages throughout
Order Functionality
Reduces products' inventory	Yes
Cannot order products that are out of stock	Yes
Changes order state	Yes
Clears current cart	Yes
Database
ERD includes all necessary tables and relationships	Yes
Table relationships	Good
Models
Validation rules for Models	Yes
Business logic is in the models	Yes - though room for improvement based on the amount of logic in the views
Controllers
Controller Filters used to DRY up controller code	Yes
Testing
Model Testing	These tests look really good! You did a great job of coming up with many different scenarios and covering those.
Controller Testing	You generally did a really nice job with controller tests as well. Nice job.
Session Testing	Yes
SimpleCov at 90% for controller and model tests
Front-end
The app is styled to create an attractive user interface	Yes
Content is organized with HTML5 semantic tags	Yes
CSS is DRY	Yes
Overall	Overall, you did a nice job with this. I can tell that you really spent a lot of time working through testing your application. Your hard work shows. There are a few places where I'd like to see logic moved from views into the model to keep separation of concerns.

Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it.

kariabancroft · 2018-05-07T05:41:31Z

config/routes.rb

+  get '/cartitems', to: 'cartitems#index', as: 'cart'
+  delete '/cartitems/:id', to: 'cartitems#destroy', as: 'delete_cartitem'
+  patch '/cartitems/:id', to: 'cartitems#update', as: 'update_cartitem'
+  patch '/cartitems/ship/:id', to: 'cartitems#ship', as: 'ship'


The restful route would have the ID between the resource and the action - /cartitems/:id/ship

kariabancroft · 2018-05-07T16:30:36Z

app/controllers/products_controller.rb

@@ -0,0 +1,69 @@
+class ProductsController < ApplicationController
+  before_action :find_product, only: [:show, :edit, :update, :destroy, :retire]
+  before_action :require_login, except: [:index, :show]


Nice job using except here as the list gets long

kariabancroft · 2018-05-07T16:32:10Z

db/schema.rb

+    t.datetime "created_at", null: false
+    t.datetime "updated_at", null: false
+    t.bigint "user_id"
+    t.string "product_status"


I would not choose product_status as a column on the products table - the extra "product" part of the column name is unnecessary

kariabancroft · 2018-05-07T17:06:59Z

app/controllers/cartitems_controller.rb

+
+  def index
+    if session[:order_id] == nil
+      order = Order.create!(state: 'pending')


I think that it is a good idea to create the order if it doesn't yet exist - but what if there is an issue here with creating the order?

kariabancroft · 2018-05-07T17:07:58Z

app/controllers/cartitems_controller.rb

+    else
+      @cart_item = Cartitem.new(cartitem_params)
+      #  find the product from path
+      @cart_item.product = Product.find(params[:product_id])


What if the product isn't found?

kariabancroft · 2018-05-07T18:48:36Z

test/models/cartitem_test.rb

+        quantity: 3
+      )
+
+      result = cart_item.valid?


Checking the validity of the item is not checking that it can be created. You still need to call .save or .create at some point.

kariabancroft · 2018-05-07T19:15:05Z

test/controllers/orders_controller_test.rb

+      Order.count.must_equal old_order_count
+
+
+      # with future date more than 5 years


These are all great test cases, and I'd recommend that they'd all be their own test. When trying to figure out if things should be their own test, I try to think: Is there more than one specific set of code that would need to change to fail this test? If so, it might be good to split it out.

kariabancroft · 2018-05-07T19:20:32Z

test/controllers/orders_controller_test.rb

+      @order.name.wont_equal @order_data[:name]
+
+
+      # without zipcode


This is the same fundamental test and with pieces of the data changed. Can you think of how you could consolidate to be able to use a loop rather than repeating the tests each time?

kariabancroft · 2018-05-07T19:23:16Z

test/controllers/products_controller_test.rb

+        user_id: User.first.id
+      }
+      # Assumptions
+      product = Product.new(@product_data1)


This is a controller test that is never executing a controller action

kariabancroft · 2018-05-07T19:25:07Z

test/controllers/reviews_controller_test.rb

@@ -0,0 +1,45 @@
+require "test_helper"
+
+describe ReviewsController do


It'd be good to check that a user can't review their own products

MississippiBrenn and others added 30 commits April 20, 2018 15:49

Merge branch 'master' of github.com:karinnainiguez/betsy

a757026

karinna v

Merge branch 'review_controller'

34b4d6a

Merging with 3versions Friday afternoon

dbbe5bd

changes for tests to pass

5a51367

Additional controller functionality

bff48bc

wrote controller show method tests for category

c057021

resolved merge conflicts

94549e4

Pulling down from local master

5ec5fdc

Merge branch 'master' into product-controller

75c94b5

yes

Add new, create, edit, and update controller methods for user

a7fe413

Resolved Conflict

8571307

create and new controller actions and tests for categories

baca494

Merging with other teammates

1a620f7

Merge branch 'master' of github.com:karinnainiguez/betsy

2ac9303

Merge branch 'user_controller'

7f2ce7d

destroy action for category controller

52bab82

Added controller tests and views

e47c139

Add controller tests for index, show, new, and edit

7f13d82

Merge branch 'product-controller'

74ebc25

Merge branch 'user_controller'

ff4d674

added model test for select_with_product method in categories

c0906e5

Add product seed data

d73f959

Merge branch 'master' of https://github.com/karinnainiguez/betsy

5ad53a6

seed data

006cbe4

Merge branch 'master' of github.com:karinnainiguez/betsy

c917372

created csv files for users and reviews

e56d43b

merging seed data

3841333

Edit csv files

1c374e1

Merge branch 'master' of https://github.com/karinnainiguez/betsy

a2fada5

seed users

928872f

karinnainiguez and others added 21 commits April 26, 2018 19:53

fix mark as shipped button

0c5dc6e

Merge branch 'master' of https://github.com/karinnainiguez/betsy

e92e5a4

More tries with icon

0f92a92

Merge branch 'master' of github.com:karinnainiguez/betsy

4b7d5c1

edit form to take month and yearand refactor tests to have more coverage

5817e49

Roolled back star ratings

0eef8d5

heroku push edits

b873d54

heroku

25abfe0

trying to fix heroku

ef2e337

fix line breaks in css

f15c2a0

merge conflicts resolved

1de7ce2

fixing https vs http

dd9e13e

Merge branch 'master' of https://github.com/karinnainiguez/betsy

4b9d7f6

css changes

5e2bdcd

adding not found picture

4f115f9

default image added

0b34f25

fixed default image

22297f0

default image heroku fix

6f0a068

take out default pic

9babf5b

ANOTHER ONE

b74ea87

what is life

53f6cfe

karinnainiguez changed the title ~~pEtsy fEels - Angela, Cara, Dikla, Karinna - Octos~~ Angela, Cara, Dikla, Karinna - pEtsy fEels - Octos Apr 27, 2018

kariabancroft reviewed May 7, 2018

View reviewed changes

karinnainiguez added 6 commits October 16, 2018 10:13

Replacing readme

fb4acdf

Refactor - spell check and readme update

95d9271

Readme Update

cd254ca

Update emojis

7522aad

refactoring readme

b550966

Adding picture

1ae506e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Angela, Cara, Dikla, Karinna - pEtsy fEels - Octos #21

Angela, Cara, Dikla, Karinna - pEtsy fEels - Octos #21

Uh oh!

karinnainiguez commented Apr 27, 2018 •

edited

Loading

Uh oh!

kariabancroft commented May 7, 2018

Uh oh!

kariabancroft May 7, 2018

Uh oh!

kariabancroft May 7, 2018

Uh oh!

kariabancroft May 7, 2018

Uh oh!

kariabancroft May 7, 2018

Uh oh!

kariabancroft May 7, 2018

Uh oh!

kariabancroft May 7, 2018

Uh oh!

kariabancroft May 7, 2018

Uh oh!

kariabancroft May 7, 2018

Uh oh!

kariabancroft May 7, 2018

Uh oh!

kariabancroft May 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		Order.count.must_equal old_order_count


		# with future date more than 5 years

		@@ -0,0 +1,45 @@
		require "test_helper"

		describe ReviewsController do

Angela, Cara, Dikla, Karinna - pEtsy fEels - Octos #21

Are you sure you want to change the base?

Angela, Cara, Dikla, Karinna - pEtsy fEels - Octos #21

Uh oh!

Conversation

karinnainiguez commented Apr 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

bEtsy

Comprehension Questions

Uh oh!

kariabancroft commented May 7, 2018

bEtsy

What We're Looking For

Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

karinnainiguez commented Apr 27, 2018 •

edited

Loading