Skip to content

Conversation

@Oh-KPond
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? This means that the code can be executed at any time while other code is being loaded.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? The call to axios is executed asynchronously, and because of this there is code that will either catch the successful response (.then) or catch (.catch) the errors.
What kind of errors might the API give you? How did you choose to handle them? In attempting to post to the API, the API might tell me that information is missing. I chose to put this information in a message for the user and outline the fields where there might be error in red. This could be fine-tuned with an if statement about which errors came back and which inputs could be outlined in red.
Do you have any recommendations on how we could improve this project for the next cohort? I enjoyed this project and thought it was good practice for the basics of we're learning. There could be more discussion about design beforehand.

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene As usual good commits and commit messages
Comprehension questions Check
Functionality
Click a button to list trips Check
Click a trip to see trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user Well done, reporting validation error as well
Styling It looks ok, it's not fully responsive however
Under the Hood
Trip data is retrieved using from the API Check
JavaScript is well-organized and easy to read Check
HTML is semantic Check, div elements just used for grouping
Overall Well done, you hit all the learning goals and more! Very nice work figuring out the create trip form. Excellent submission

return createFormData;
}

const createClearForm = () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be an unused function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants