Skip to content

Conversation

@CheerOnMars
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means my code can do many things at the same time.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? The reserve a trip option appears only when viewing the specific trip.
What kind of errors might the API give you? How did you choose to handle them? The API requires an email, name, and a defined trip.
Do you have any recommendations on how we could improve this project for the next cohort?

reportStatus(content);
};

const loadtrips = () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be camel case!

console.log();
reportStatus(`Successfully loaded trip #${id}`);
let trip = response.data;
let tripID_res = trip.id
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this variable do?

@tildeee
Copy link

tildeee commented Jun 1, 2018

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
Functionality
Click a button to list trips x
Click a trip to see trip details x
Fill out a form to reserve a spot x
Errors are reported to the user x
Styling x
Under the Hood
Trip data is retrieved using from the API x
JavaScript is well-organized and easy to read x
HTML is semantic x
Overall

Hey! Looks good,

the project functions how I expected. The code looks good!

I've made a few comments but otherwise, good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants