Skip to content

Conversation

@Lasiorhine
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Parts of it can execute in response to predetermined events.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Each major chunk (the detail view, the reservation box, etc) is executed in response to a button-click.
What kind of errors might the API give you? How did you choose to handle them? If you don't enter a name and/or email in the reservation screen, you'll get an error telling you that the field can't be blank. This error is dispensed via the relevant axios method's .then promise.
Do you have any recommendations on how we could improve this project for the next cohort? Be clearer about the styling expectations. I didn't find out about the 'foundation' requirement until I looked at the feedback form (after hearing that styling on this project was NBD) and by that time, it was way too late for me.

@tildeee
Copy link

tildeee commented May 29, 2018

victoria omg lolololol i'm laughing so hard right now!!!!!;alkdjfasdf
screen shot 2018-05-29 at 10 24 15 am
screen shot 2018-05-29 at 10 26 09 am
screen shot 2018-05-29 at 10 26 23 am

axios.post(reserveTripUrl, reservationData)
.then((response) => {
console.log(response);
reservationScreen.empty();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I fill out the reservation form correctly to make a reservation, I actually get an unexpected error... that's because reservationScreen is undefined at this point, and it kicks it over to the .catch((error) {}) part.

I fixed it by adding const reservationScreen = $('#reservation-box'); before this line

@tildeee
Copy link

tildeee commented May 29, 2018

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions The "Foundation requirement" was an artifact from the feedback form not being updated; it's now updated-- no worries about using Foundation + our bad!!!!!
Functionality
Click a button to list trips x
Click a trip to see trip details x
Fill out a form to reserve a spot x, one tiny bug I've made a comment on
Errors are reported to the user x
Styling h e l l y e s
Under the Hood
Trip data is retrieved using from the API x
JavaScript is well-organized and easy to read x
HTML is semantic x
Overall

Good work on this!

The code looks good! I like your approach to using the trip id on id in each one.

It works really well and I like your solution.

ALSO I REALLY LIKE YOUR SITE

<input type='email' id='email' name='email'><br>
<label>&nbsp;</label>
<input type='submit' id='submit-reservation-info'
value='I hereby commit to unapologetically trekking up my life'><br>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You use <br> tags here... which isn't a no-no, it's quite common to use those in forms, but have you considered using css to make them all display: block;?


.success_message {
color: fuchsia;
background-color: khaki;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful color combination. also, i had no idea fuchsia was spelled like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants