Caroline Nardi - Trek - Octos #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peating on each load call.
TREKWhat We're Looking For
|
|
|
||
| html += `<h2>Trip Details</h2> | ||
| <div> | ||
| <h3>Name: ${this.innerHTML}<h3> |
There was a problem hiding this comment.
It might make sense to break the code to render trip details out into a separate function - as is, this function is doing two things (making the request, and rendering data). See also http://callbackhell.com/
| $(document).ready(() => { | ||
| $("#load-trips").click(loadTrips); | ||
| $("#trip-list").on("click", "li", loadTripDetails); | ||
| $("#trip-list").on("click", "li", loadReserveTrip); |
There was a problem hiding this comment.
Rather than running loadReserveTrip immediately when a trip is clicked, it might work better to only load it when the GET request for the individual trip comes back. That is, call that function from within the then callback of loadTripDetails.
| const loadReserveTrip = function loadReserveTrip() { | ||
|
|
||
| const reserveTrip = $("#reserve-trip"); | ||
| reserveTrip.empty(); |
There was a problem hiding this comment.
I like the idea of breaking this code out into a separate function. Good organization!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TREK
Congratulations! You're submitting your assignment!
Comprehension Questions